react icon indicating copy to clipboard operation
react copied to clipboard

Preparatory refactor for snapshot testing for #4794

Open siddharthkp opened this issue 1 year ago • 2 comments

  • Preparatory PR for https://github.com/primer/react/pull/4794

Refactored the snapshot test file to make it easier split by theme and feature flags. (Add new scenarios in the future)

Rollout strategy

  • [ ] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [x] None; updates internal tests only

Testing & Reviewing

Merge checklist

  • [x] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

siddharthkp avatar Aug 27 '24 15:08 siddharthkp

⚠️ No Changeset found

Latest commit: 798008ed35e98d5364d6c0d913996b0305c94ca6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 27 '24 15:08 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.34 KB (0%)
packages/react/dist/browser.umd.js 96.61 KB (0%)

github-actions[bot] avatar Aug 27 '24 15:08 github-actions[bot]