react icon indicating copy to clipboard operation
react copied to clipboard

ActionList: Add more checks for `ActionList.Item` when using button semantics

Open TylerJDev opened this issue 1 year ago • 3 comments

Part of https://github.com/github/primer/issues/3722

Changelog

New

Changed

Removed

Rollout strategy

  • [ ] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

TylerJDev avatar Aug 23 '24 19:08 TylerJDev

🦋 Changeset detected

Latest commit: 84aaff88d67ce1694cd6d8203038dccebb639b30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 23 '24 19:08 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.17 KB (+0.09% 🔺)
packages/react/dist/browser.umd.js 97.48 KB (-0.01% 🔽)

github-actions[bot] avatar Aug 23 '24 19:08 github-actions[bot]

:wave: Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/344691

primer-integration[bot] avatar Sep 30 '24 15:09 primer-integration[bot]

👋🏻 Bumping this for priority. The associated issue to this PR https://github.com/github/primer/issues/3722 was listed as a short term repair item, which has an SLA for repair of 60 days and we are now 51 days overdue. Sid is out of office right now so we'll need to identify another reviewer. @camertron as the other engineer tagged for review, could you please add this to your queue to get reviewed this week or very early next week?

lesliecdubs avatar Oct 17 '24 21:10 lesliecdubs

:wave: Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

github-actions[bot] avatar Oct 17 '24 22:10 github-actions[bot]