react icon indicating copy to clipboard operation
react copied to clipboard

TreeView: Add accessible names to `LeadingVisual`

Open TylerJDev opened this issue 1 year ago • 2 comments

Closes https://github.com/github/primer/issues/3444

Changelog

New

  • Adds accessible names (aria-label) to leading visuals in TreeView story
  • Adjusts "Without Indentation" story based on feedback

Rollout strategy

  • [ ] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [x] None; if selected, include a brief description as to why (Storybook specific)

Testing & Reviewing

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [x] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [x] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

TylerJDev avatar Aug 22 '24 18:08 TylerJDev

⚠️ No Changeset found

Latest commit: 4099a779bf3937fca590fb8783d53b32f0de2ade

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 22 '24 18:08 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.32 KB (0%)
packages/react/dist/browser.umd.js 96.65 KB (0%)

github-actions[bot] avatar Aug 22 '24 18:08 github-actions[bot]