react icon indicating copy to clipboard operation
react copied to clipboard

refactor(ButtonBase): To use CSS modules behind the feature flag

Open langermank opened this issue 1 year ago • 3 comments

Part of https://github.com/github/primer/issues/3815

Changelog

Changed

  • The ButtonBase component uses CSS modules behind the flag

Rollout strategy

  • Minor release

Testing & Reviewing

Snapshots should match with flag on/off

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

langermank avatar Aug 08 '24 00:08 langermank

🦋 Changeset detected

Latest commit: b0bd7ad1d66a6f2aed836a3ca54d752e714455cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 08 '24 00:08 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.85 KB (+0.23% 🔺)
packages/react/dist/browser.umd.js 97.28 KB (+0.4% 🔺)

github-actions[bot] avatar Aug 20 '24 15:08 github-actions[bot]

:wave: Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/339048

primer-integration[bot] avatar Aug 23 '24 20:08 primer-integration[bot]