SelectPanel: Update SelectPanel to use modern ActionList

[broccolinisoup]

Closes #

Changelog

New

Changed

Removed

Rollout strategy

• [x] Patch release
• [ ] Minor release
• [ ] Major release; if selected, include a written rollout or migration plan
• [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• [ ] Added/updated tests
• [ ] Added/updated documentation
• [ ] Added/updated previews (Storybook)
• [ ] Changes are SSR compatible
• [ ] Tested in Chrome
• [ ] Tested in Firefox
• [ ] Tested in Safari
• [ ] Tested in Edge
• [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 0b5720624f1d18d1b11340471e1647d8374a388c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions[bot]]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	96.86 KB (+0.46% 🔺)
packages/react/dist/browser.umd.js	97.18 KB (+0.55% 🔺)

[siddharthkp]

deprecated/ActionList supports renderItem escape hatch. We need to either support renderItem or remove instances of it.

• [x] ui/packages/github-hosted-runners-settings/views/components/shared/RunnerGroupSelector.tsx#L93
• [x] ui/packages/copilot-chat/components/ReferencesSelectPanel.tsx#L257
• [ ] ui/packages/memex/src/stories/navigation/enabled-features-picker.tsx#L94C23-L94C23
• checking if there are more that are indirectly forwarded to SelectPanel

There are probably not too many of them, but editing them is a lot of work that we should not take up right now. We should support renderItem before we can remove it safely :(

[siddharthkp]

Next step: Feature flag

Update: Done!

[siddharthkp]

• Preparatory refactor for running snapshot tests with flag on and off https://github.com/primer/react/pull/4886

[primer-integration[bot]]

:wave: Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/339537

Update: These tests are passing

[siddharthkp]

Next steps:

• [x] ✅ Run integration tests with flag off
• [x] ✅ Run integration tests with flag on
  • [x] Debug why empty item from memex is not rendering
• [x] https://github.com/github/github/pull/339699
• [ ] Need to remove unrelated visual changes

[siddharthkp]

Next steps:

• [ ] Get PR review
• [x] (non blocker) Need to debug unrelated visual changes (this PR introduces the tiniest change in contrast that doesn't matter in the long run, but would be nice to pin down)

[joshblack]

Also wanted to leave a question, would it be possible for this to go in the next release batch? (I think it would be rc.5)

Would help out a ton on my end, the release is starting to get big 😅

[siddharthkp]

Also wanted to leave a question, would it be possible for this to go in the next release batch? (I think it would be rc.5)

Absolutely! I can wait :)

Update: rc.4 was merged yesterday, can merge this now 🎉

[broccolinisoup]

So happy to see this is merged!! Thanks @siddharthkp 🥹 💖