react icon indicating copy to clipboard operation
react copied to clipboard

refactor: remove stub folders for TypeScript resolution

Open joshblack opened this issue 1 year ago • 3 comments

Closes https://github.com/github/primer/issues/3665

Changelog

New

Changed

Removed

  • The codemods folder has been removed as it is no longer needed. If we would like to use this in the future, we can revisit where we would like this to live 👀
  • The stub folders for TypeScript resolution have been removed

Rollout strategy

  • [x] Major release; if selected, include a written rollout or migration plan

I believe the removal of the stub folders will trigger any consumer using Primer React and the node moduleResolution option may end up seeing an issue when importing from sub-paths. As a result, they should update their moduleResolution option to node16 or higher

joshblack avatar Jul 26 '24 18:07 joshblack

🦋 Changeset detected

Latest commit: bf5b3c453092160a5a9e0892a8a9950e76fc5466

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 26 '24 18:07 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.14 KB (0%)
packages/react/dist/browser.umd.js 98.63 KB (0%)

github-actions[bot] avatar Jul 26 '24 19:07 github-actions[bot]

:wave: Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/343976

primer-integration[bot] avatar Sep 25 '24 15:09 primer-integration[bot]