react icon indicating copy to clipboard operation
react copied to clipboard

Dialog: Support a responsive value for `isOpen`

Open maximedegreve opened this issue 1 year ago • 2 comments

Description

In some cases you want to display data in a dialog on mobile but on desktop keep it on the page. This is currently not possible with this component due to the lack of responsive support on the isOpen value. Wrapping the dialog in a div and setting display: none on smaller breakpoints neither works.

Steps to reproduce

<Box sx={{ display: ['block', 'block', 'none'] }}>
     <Dialog title={TITLE} onClose={onClickClose}>test</Dialog
</Box>

Version

Latest

Browser

Safari

maximedegreve avatar Jul 19 '24 09:07 maximedegreve

Notes from Maintainer Sync (July 22nd)

Context from Slack: https://github.slack.com/archives/GACAW0NPM/p1721383080023129

We're going to leave this in the inbox this week while waiting for the conversation in Slack to resolve 👀

joshblack avatar Jul 22 '24 15:07 joshblack

Notes from Maintainer Sync (August 5th)

It might be a good idea to experiment / prototype how this would work, testing focus management, declarative buttons of a Dialog, etc.

We should revisit this in a future planning cycle to see if we can dedicate some time to the explorations mentioned. Please let us know if there is any urgency around this sooner.

lesliecdubs avatar Aug 05 '24 15:08 lesliecdubs

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Feb 01 '25 16:02 github-actions[bot]