Accessibility fixes for ToggleSwitch

[TylerJDev]

Closes https://github.com/github/primer/issues/3463

Stemming from @camertron's work in https://github.com/primer/react/pull/3902

Example story

Changelog

New

• Adds new props loadingLabelDelay and loadingLabel

Changed

• Makes aria-labelledby a required prop
• Utilizes aria-disabled instead of disabled

Rollout strategy

• [ ] Patch release
• [x] Minor release
• [ ] Major release; if selected, include a written rollout or migration plan
• [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• [x] Added/updated tests
• [x] Added/updated documentation
• [x] Added/updated previews (Storybook)
• [ ] Changes are SSR compatible
• [x] Tested in Chrome
• [x] Tested in Firefox
• [x] Tested in Safari
• [ ] Tested in Edge
• [x] (GitHub staff only) Integration tests pass at github/github. ⚠️ Requires small test change to pass.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 3d240415fa66f7c55f76a1565a07009c53d00306

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions[bot]]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	90.23 KB (+0.23% 🔺)
packages/react/dist/browser.umd.js	90.47 KB (+0.39% 🔺)

[TylerJDev]

@joshblack - if you get the chance, I'd love a review from you on this PR, mainly because I added onto Announce.tsx, and I want to make sure it's the right change :grin:

[lesliecdubs]

Heads up @tylerjdev, Josh is out of office for a bit (check our team calendar for dates). Feel free to leave it until then, but wanted to let you know in case it made sense to request a different reviewer.

[github-actions[bot]]

:wave: Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[github-actions[bot]]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

[lesliecdubs]

👋🏻 @TylerJDev should we revisit this one to get it merged in?

[TylerJDev]

@lesliecdubs, definitely! Will put this on my to-do for next week to ship! 🚢

[github-actions[bot]]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

[TylerJDev]

To be unblocked by https://github.com/github/github/pull/371043. Once merged, this PR should be good to ship!

[github-actions[bot]]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

[TylerJDev]

@joshblack, mind giving this one another quick review? Shouldn't include any additional changes since the last approval, but it's been a bit since then 😅

[github-actions[bot]]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

[github-actions[bot]]

:wave: Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

[github-actions[bot]]

:wave: Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

[primer-integration[bot]]

:wave: Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/394584

[primer-integration[bot]]

🟢 golden-jobs completed with status success.

[github-actions[bot]]

:wave: Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

[github-actions[bot]]

:wave: Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!