ButtonGroup: Fix button and icon button styling when tooltips are used on them
Closes https://github.com/primer/react/issues/4129
Changelog
New
Changed
- With this PR, we are wrapping button group items with a div. The main reason is to simplify CSS selection. You can view the previous attempt to write a CSS to fix styling issues both for tooltip v1 and v2 on button group.
- Enhanced CSS selection for the ButtonGroup children elements to ensure buttons and links still look the same if there are tooltips on them
Removed
Rollout strategy
- [x] Patch release
- [ ] Minor release
- [ ] Major release; if selected, include a written rollout or migration plan
- [ ] None; if selected, include a brief description as to why
Testing & Reviewing
Merge checklist
- [x] Added/updated tests
- [ ] Added/updated documentation
- [x] Added/updated previews (Storybook)
- [ ] Changes are SSR compatible
- [ ] Tested in Chrome
- [ ] Tested in Firefox
- [ ] Tested in Safari
- [ ] Tested in Edge
- [x] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)
🦋 Changeset detected
Latest commit: 08df44e66f2dc72568d49e7cebf4a3cd54bbe01b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @primer/react | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
size-limit report 📦
| Path | Size |
|---|---|
| packages/react/dist/browser.esm.js | 92.49 KB (+0.09% 🔺) |
| packages/react/dist/browser.umd.js | 92.72 KB (+0.05% 🔺) |
:wave: Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/332533
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.
closing in favour of https://github.com/primer/react/pull/5123