react icon indicating copy to clipboard operation
react copied to clipboard
verified publisher icon primer

containsCurrentItem State Not Reset in NavList Component.

Open Hanskrogh opened this issue 1 year ago • 1 comments

Description

When the navlist component includes a subnav and there is a current item within that subnav, the containsCurrentItem state is not being reset to false. As a result, the visual indication of the current item remains displayed until the component is fully re-rendered.

Steps to reproduce

  1. Add a subnav within the navlist component.
  2. Ensure there is a current item within the subnav.
  3. Observe that the containsCurrentItem state remains true even after the current item is no longer relevant.

Version

36.24.0

Browser

Chrome

Hanskrogh avatar Jul 07 '24 08:07 Hanskrogh

Hello @TylerJDev 👋 Would you be able to review the PR https://github.com/primer/react/pull/4722 that @Hanskrogh pushed? Thanks!!

broccolinisoup avatar Jul 16 '24 05:07 broccolinisoup

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Jan 12 '25 06:01 github-actions[bot]

Closing as stale. Please comment back or reopen if this requires additional attention.

lesliecdubs avatar Jan 14 '25 21:01 lesliecdubs