react icon indicating copy to clipboard operation
react copied to clipboard

ActionList: Ensure `variant` is respected when `full`

Open TylerJDev opened this issue 1 year ago • 3 comments

Closes #

Changelog

New

Changed

Removed

Rollout strategy

  • [ ] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

TylerJDev avatar Jun 28 '24 23:06 TylerJDev

🦋 Changeset detected

Latest commit: 1f96ef5bb30f4ce55da79ceb5bc84d11a0213f20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 28 '24 23:06 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.11 KB (+0.16% 🔺)
packages/react/dist/browser.umd.js 91.29 KB (+0.06% 🔺)

github-actions[bot] avatar Jun 28 '24 23:06 github-actions[bot]

:wave: Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/331186

primer-integration[bot] avatar Jun 28 '24 23:06 primer-integration[bot]

Just wanted to ask if there was a good way to add a test for this kind of change. Is this something that VRT could help out with or would this be more of a Jest thing?

That's a good point! I think a VRT would be perfect! I believe this wasn't caught because we don't test for variant: full in our VRT e2e tests. I'll follow up with a story that utilizes variant: full.

TylerJDev avatar Jul 01 '24 15:07 TylerJDev