react icon indicating copy to clipboard operation
react copied to clipboard

test(SelectPanel): update tests to account for more of API

Open joshblack opened this issue 1 year ago • 2 comments

As we're working more on the v1 of SelectPanel, I wanted to add some additional tests to the test suite.

This is not complete coverage but figured I'd add what I could this week and revisit another time for what was missed

Changelog

New

Changed

  • Update tests for Select Panel

Removed

Rollout strategy

  • [x] None; if selected, include a brief description as to why

This is a change that adds tests to Select Panel

joshblack avatar Jun 28 '24 16:06 joshblack

⚠️ No Changeset found

Latest commit: 79e8cc5cfecbfdb04aa9a8cc8b772318977cf870

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 28 '24 16:06 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.97 KB (0%)
packages/react/dist/browser.umd.js 91.25 KB (0%)

github-actions[bot] avatar Jun 28 '24 16:06 github-actions[bot]

bump @siddharthkp when you get a sec 👀

joshblack avatar Jul 03 '24 14:07 joshblack

@broccolinisoup my understanding since we're keeping the combobox-related functionality is that it should mostly be the same behavior, if I remember right 👀

joshblack avatar Jul 16 '24 16:07 joshblack

@broccolinisoup my understanding since we're keeping the combobox-related functionality is that it should mostly be the same behavior, if I remember right 👀

Oh this is great! Thanks for sharing that.

broccolinisoup avatar Jul 16 '24 22:07 broccolinisoup