react icon indicating copy to clipboard operation
react copied to clipboard

fix(FilteredActionList): label listbox by input

Open joshblack opened this issue 1 year ago • 2 comments

Closes https://github.com/github/primer/issues/3408

Fixes https://dequeuniversity.com/rules/axe/4.7/aria-input-field-name for FilteredActionList and SelectPanel by labeling the listbox by the input

Changelog

New

Changed

  • Add id to input for FilteredActionList
  • Label listbox by input id

Removed

Rollout strategy

  • [x] Patch release

Testing & Reviewing

  • [ ] Verify that the axe violation for this no longer occurs

joshblack avatar Jun 27 '24 15:06 joshblack

⚠️ No Changeset found

Latest commit: 441e6491bf70d521ae0a35e288b18aca3d81f5da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 27 '24 15:06 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.96 KB (-0.06% 🔽)
packages/react/dist/browser.umd.js 91.34 KB (-0.03% 🔽)

github-actions[bot] avatar Jun 27 '24 15:06 github-actions[bot]