react icon indicating copy to clipboard operation
react copied to clipboard

Do not merge: Update the default value of `unsafeDisableTooltip` to `false` and remove redundant props and wrappers

Open broccolinisoup opened this issue 1 year ago • 2 comments

Closes https://github.com/primer/react/issues/2008 Related https://github.com/primer/react/issues/4696

[!CAUTION] We will hold off merging this until we complete the roll out at dotcom. (Watch the progress here (internal link only))

Changelog

Changed

  • The default value of unsafeDisableTooltip to false
  • Added unsafeDisableTooltip={true} a coupe of IconButton instances where it is not safe to enable tooltips.

Removed

  • Explicit Tooltip wrappers
  • unsafeDisableTooltip={false} prop since it is the default value now.

Rollout strategy

  • [ ] Patch release
  • [x] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [x] Added/updated tests
  • [ ] Added/updated documentation
  • [x] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [x] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

broccolinisoup avatar Jun 27 '24 05:06 broccolinisoup

🦋 Changeset detected

Latest commit: fd6bd5749e04dcc7b14a5aadaacfe9e08317f2a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 27 '24 05:06 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.05 KB (-0.08% 🔽)
packages/react/dist/browser.umd.js 91.38 KB (+0.04% 🔺)

github-actions[bot] avatar Jun 27 '24 05:06 github-actions[bot]

:wave: Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/332110

primer-integration[bot] avatar Jul 09 '24 00:07 primer-integration[bot]

Integration tests pass https://github.com/github/github/pull/332110 and tested on RL, everything looks good 🎉

broccolinisoup avatar Jul 09 '24 03:07 broccolinisoup