react icon indicating copy to clipboard operation
react copied to clipboard

Add TrailingAction support to NavList

Open khiga8 opened this issue 1 year ago • 4 comments

Fixes: https://github.com/github/primer/issues/1966 Unblocks: https://github.com/github/accessibility-audits/issues/2942

Changelog

New

This PR adds TrailingAction support to NavList, extending the support we added to ActionList in https://github.com/primer/react/pull/4634.

Rollout strategy

  • [x] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [x] Added/updated tests
  • [x] Added/updated documentation
  • [x] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [x] Tested in Chrome
  • [x] Tested in Firefox
  • [x] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

khiga8 avatar Jun 25 '24 13:06 khiga8

🦋 Changeset detected

Latest commit: 27e01a81623dbee96fd4aa024af6ccdf5eeeda64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 25 '24 13:06 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.07 KB (+0.12% 🔺)
packages/react/dist/browser.umd.js 91.32 KB (+0.08% 🔺)

github-actions[bot] avatar Jun 25 '24 13:06 github-actions[bot]

The failing test is a snapshot test which seems to be failing unrelated to my changes.

khiga8 avatar Jun 25 '24 14:06 khiga8

The test failure seems unrelated to my changes. It looks like changes in ID in the jest snapshot tests 🤔 . Any suggestions for moving forward here @primer/react-reviewers?

khiga8 avatar Jun 27 '24 14:06 khiga8