react icon indicating copy to clipboard operation
react copied to clipboard

Utilize `aria-describedby` on all `ActionList` descriptions

Open TylerJDev opened this issue 1 year ago • 2 comments

Closes https://github.com/github/primer/issues/2501

Changelog

Changed

  • Added aria-describedby to inline description
  • Added aria-labelledby to ActionList.TrailingVisual

Rollout strategy

  • [x] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [x] Added/updated tests
  • [ ] Added/updated documentation
  • [x] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [x] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

TylerJDev avatar Jun 11 '24 18:06 TylerJDev

🦋 Changeset detected

Latest commit: cf0063042f7f72c9c57a1afc79f78f6102462bcf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 11 '24 18:06 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 95.85 KB (+0.1% 🔺)
packages/react/dist/browser.umd.js 96.11 KB (+0.05% 🔺)

github-actions[bot] avatar Jun 11 '24 18:06 github-actions[bot]

@primer/engineer-reviewers - Could I get a review on this PR? :eyes:

TylerJDev avatar Jul 12 '24 20:07 TylerJDev