react icon indicating copy to clipboard operation
react copied to clipboard

Check integration test results

Open siddharthkp opened this issue 1 year ago • 3 comments

Context

I'd like to fetch and report the result of golden-jobs-results on the PR as a CI check and comment.

Strategy 1: Pull (implemented here)

  1. Check if there is a PR related to current branch
  2. Check if the CI workflows have run
  3. Check if golden-jobs-results has completed yet
  4. Check results of golden-jobs-results

Strategy 2: Push (probably better!)

  1. Inform PR has been created (based on label)
  2. (maybe) inform golden-jobs-results has started/expected
  3. Inform golden-jobs-results has completed with results (based on label)

Questions I need to think more about:

  1. What triggers this workflow?
  2. Can this workflow be re-triggered manually?
  3. Is it workflow required or just recommended?
  4. What happens when this workflow fails for reasons not related to your PR/change
  5. Pushing another commit should invalidate the results, right?

Rollout strategy

  • [x] None; workflow only change.

siddharthkp avatar May 16 '24 14:05 siddharthkp

⚠️ No Changeset found

Latest commit: b436453cb286e3a4203af54d02f5fe26472fbb02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 16 '24 14:05 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.49 KB (0%)
packages/react/dist/browser.umd.js 88.84 KB (0%)

github-actions[bot] avatar May 16 '24 14:05 github-actions[bot]

Integration PR has been created

primer-integration[bot] avatar Jun 04 '24 15:06 primer-integration[bot]