react icon indicating copy to clipboard operation
react copied to clipboard

TreeView Item: account for the {Space} key event

Open randall-krauskopf opened this issue 1 year ago • 2 comments

Related To: https://github.com/github/primer/issues/3057

Before

For some reason my keystroke logger wasn't registering Space events but the pauses before the Return events involves me pressing the Space key but not toggle event occurring

https://github.com/primer/react/assets/104226843/41905dc9-3ba0-4f18-a9c2-a1cc3aadbe7a

After

For some reason my keystroke logger wasn't registering Space events but the toggle events that occur before the Return based ones involve me pressing the Space key.

https://github.com/primer/react/assets/104226843/25e04b17-f4f3-4487-9776-d0c833489454

Changelog

New

Changed

Removed

Rollout strategy

  • [x] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [x] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

randall-krauskopf avatar May 01 '24 17:05 randall-krauskopf

🦋 Changeset detected

Latest commit: 70f9ebc38e9b2031db9c58163fe57b122b1e19be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 01 '24 17:05 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.31 KB (+0.08% 🔺)
packages/react/dist/browser.umd.js 88.57 KB (-0.12% 🔽)

github-actions[bot] avatar May 01 '24 17:05 github-actions[bot]

@randall-krauskopf is OOO and this looks pretty straightforward, so I'll be taking it over and getting it shipped.

iansan5653 avatar May 08 '24 15:05 iansan5653