Make sure Link is underlined when `inline={true}`
Related to https://github.com/github/primer/issues/2099
Currently, the inline property only works in combination with the data-a11y-link-underlines attribute. However, the link should always be underlined if inline is set to true and no attribute is provided.
Changelog
Changed
If inline is set to true, the Link will be underlined even if not using the data-a11y-link-underlines attribute.
Rollout strategy
- [x] Patch release
- [ ] Minor release
- [ ] Major release; if selected, include a written rollout or migration plan
- [ ] None; if selected, include a brief description as to why
Testing & Reviewing
Merge checklist
- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews (Storybook)
- [ ] Changes are SSR compatible
- [ ] Tested in Chrome
- [ ] Tested in Firefox
- [ ] Tested in Safari
- [ ] Tested in Edge
- [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)
🦋 Changeset detected
Latest commit: 7088054d0f4e602da0e7df6bb9c5c60d14a10b41
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @primer/react | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
size-limit report 📦
| Path | Size |
|---|---|
| packages/react/dist/browser.esm.js | 88.03 KB (-0.01% 🔽) |
| packages/react/dist/browser.umd.js | 88.25 KB (-0.13% 🔽) |
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.