react icon indicating copy to clipboard operation
react copied to clipboard

Revert "Revert "Add support for nested submenus to `ActionMenu`""

Open iansan5653 opened this issue 1 year ago • 3 comments

Reverts primer/react#4472

iansan5653 avatar Apr 10 '24 15:04 iansan5653

🦋 Changeset detected

Latest commit: 741b14987b8b2654d56747fcbf7a8eb7f1fa684a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 10 '24 15:04 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.28 KB (+0.27% 🔺)
packages/react/dist/browser.umd.js 88.57 KB (+0.22% 🔺)

github-actions[bot] avatar Apr 10 '24 16:04 github-actions[bot]

Hi @iansan5653! Would be great to get this code back in ActionMenu. Could you list any todos to push this PR to ready and merge it? I'm happy to take it over incase you cannot prioritise it.

pksjce avatar Apr 26 '24 01:04 pksjce

What I understand is that there is no particular issue in this PR itself. But after this is merged in, we need to upgrade dotcom to use this component instead of NestableActionMenu. Approving this PR.

pksjce avatar May 06 '24 12:05 pksjce

Hi @iansan5653, our canary publishing is working smoothly again, created a integration PR to check what were the errors: https://github.com/github/github/pull/323719

siddharthkp avatar May 06 '24 14:05 siddharthkp

Thank you! Planning to get this worked out this week

iansan5653 avatar May 06 '24 18:05 iansan5653