react icon indicating copy to clipboard operation
react copied to clipboard

Fix `placeholder` selector for form components

Open langermank opened this issue 1 year ago • 2 comments

Placeholder text came up during the v8 color staff ship. It looks like the selector wasn't properly selecting, which could lead to unexpected results.

Rollout strategy

  • [ ] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

langermank avatar Feb 21 '24 20:02 langermank

🦋 Changeset detected

Latest commit: 853bda0d147371b18d0d9bbcae4d8ea0618cda51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 21 '24 20:02 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.48 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 114.16 KB (+0.02% 🔺)

github-actions[bot] avatar Feb 21 '24 20:02 github-actions[bot]