ButtonGroup: Fix button and icon button styling when tooltips are used on them (#4210)

[broccolinisoup]

Closes #4129

Reintroducing https://github.com/primer/react/pull/4210 since it is reverted due to random VRT tests failings - I removed the threshold setting in Playwright since the default one is less strict.

Changelog

New

Changed

Updated Button group CSS to make sure the icon buttons and buttons are rendered as expected when they have tooltips (both v1 and v2) on them

Removed

Rollout strategy

• [x] Patch release
• [ ] Minor release
• [ ] Major release; if selected, include a written rollout or migration plan
• [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• [ ] Added/updated tests
• [ ] Added/updated documentation
• [x] Added/updated previews (Storybook)
• [ ] Changes are SSR compatible
• [x] Tested in Chrome
• [ ] Tested in Firefox
• [ ] Tested in Safari
• [ ] Tested in Edge
• [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: f440bece068921d381748b1b63515baccb5d245c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions[bot]]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	113.64 KB (+0.07% 🔺)
packages/react/dist/browser.umd.js	114.34 KB (+0.11% 🔺)

[broccolinisoup]

Seems good from a quick pass, is it still cutting it off by 1px like you were noticing before? 👀

I think it is all gone now, removing the strict threshold worked 👍🏻

[broccolinisoup]

closing this in favour of https://github.com/primer/react/pull/4371