react icon indicating copy to clipboard operation
react copied to clipboard

Tooltip v1: Remove the caret from the tooltip to make it consistent with the new tooltip, css and rails - Do not merge

Open broccolinisoup opened this issue 1 year ago • 4 comments

Closes #

Updating the existing tooltip to match with the new tooltip styles. We need this because we won't be able to update all tooltips at dotcom to use the new version and we don't want style inconsistencies. We will do the same update on rails and css and coordinate a release together. Working with @langermank on this together.

Changelog

New

Changed

Removed

  • Caret of the tooltip is removed

Rollout strategy

  • [ ] Patch release
  • [x] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Please view the stories https://primer-5fae3091a4-13348165.drafts.github.io/storybook/?path=/story/components-tooltip--default and confirm that the caret is not present and the design matches with the updated styles

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [x] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [x] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

broccolinisoup avatar Jan 17 '24 23:01 broccolinisoup

🦋 Changeset detected

Latest commit: 6a7400357dfc4319500c61537f9d4ba1c0d05246

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 17 '24 23:01 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.43 KB (-0.13% 🔽)
packages/react/dist/browser.umd.js 114.09 KB (-0.14% 🔽)

github-actions[bot] avatar Jan 17 '24 23:01 github-actions[bot]

I think we may have also removed the animations/delay. I can't suggest to remove it because it wasn't edited here 😄

animation CSS code snippet

langermank avatar Jan 18 '24 02:01 langermank

I think we may have also removed the animations/delay. I can't suggest to remove it because it wasn't edited here 😄

Good point! We still have the animation in the v2 but no delay. I vaguely remember that we removed the animation and it was too snappy so we kept it. I pushed a commit to remove the delay. Let me know if you have concern about keeping the animation as well.

broccolinisoup avatar Jan 19 '24 08:01 broccolinisoup