react icon indicating copy to clipboard operation
react copied to clipboard

TextInput: Update TextInput.Action internal component to use Tooltip v2

Open broccolinisoup opened this issue 2 years ago • 2 comments

Closes https://github.com/primer/react/issues/4091

Changelog

New

Changed

  • Update to use the new tooltip for TextInput's trailing action
  • Update the default direction of tooltipDirection prop to s because it is what is defaulted in Tooltip

Removed

Rollout strategy

  • [ ] Patch release
  • [x] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Changes can be tested in the storybook

Merge checklist

  • [x] Added/updated tests
  • [x] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [x] Changes are SSR compatible
  • [x] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

broccolinisoup avatar Dec 21 '23 00:12 broccolinisoup

🦋 Changeset detected

Latest commit: c24979c5c213ef172680bf072e026a1991881f8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Dec 21 '23 00:12 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.57 KB (+0.12% 🔺)
packages/react/dist/browser.umd.js 114.22 KB (+0.12% 🔺)

github-actions[bot] avatar Dec 21 '23 01:12 github-actions[bot]