react icon indicating copy to clipboard operation
react copied to clipboard

memoize context value in ActionList.List

Open Freax13 opened this issue 1 year ago • 3 comments

Changelog

Changed

We now memoize the internal context value in ActionList.List. This prevents unnecessary rerenders.

Rollout strategy

  • [X] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] Integration tests pass at github/github (Learn more about how to run integration tests)

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Freax13 avatar Nov 13 '23 15:11 Freax13

🦋 Changeset detected

Latest commit: 0a83bd70a74c92b0f21de3392432e845a57258b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Nov 13 '23 15:11 changeset-bot[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Jan 13 '24 16:01 github-actions[bot]

This is still relevant,

Freax13 avatar Jan 13 '24 16:01 Freax13

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar May 05 '24 20:05 github-actions[bot]