react icon indicating copy to clipboard operation
react copied to clipboard

refactor Dialog to use <dialog> internally

Open keithamus opened this issue 2 years ago • 4 comments

Refs https://github.com/github/primer/issues/2531

This changes Dialog to use the <dialog> element internally, which allows us to delete a fair amount of code and should resolve some bugs and complexity we have with the current dialog.

Changelog

New

Changed

Dialog now uses native <dialog> under the hood.

Removed

Rollout strategy

  • [x] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

  • [x] Added/updated tests
  • [ ] Added/updated documentation
  • [x] Added/updated previews (Storybook)
  • [x] Changes are SSR compatible
  • [x] Tested in Chrome
  • [x] Tested in Firefox
  • [x] Tested in Safari
  • [x] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

keithamus avatar Oct 18 '23 11:10 keithamus

🦋 Changeset detected

Latest commit: 51c8194c8df40a04851c0183a0bb5a630f4e48fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 18 '23 11:10 changeset-bot[bot]

size-limit report 📦

Path Size
dist/browser.esm.js 104.6 KB (+0.13% 🔺)
dist/browser.umd.js 105.26 KB (+0.17% 🔺)

github-actions[bot] avatar Oct 24 '23 09:10 github-actions[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Mar 19 '24 10:03 github-actions[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar May 18 '24 12:05 github-actions[bot]