react icon indicating copy to clipboard operation
react copied to clipboard

DialogV2 does not close when clicking outside of the dialog

Open ctmayn opened this issue 2 years ago • 4 comments

Description

According to the docs in https://primer.style/react/drafts/Dialog, the dialog is modal so it should close when clicking outside of the dialog. However, clicking outside the dialog does not close it

Steps to reproduce

  1. Go to https://primer.style/react/drafts/Dialog
  2. Scroll down and click on the "Open" button
  3. The dialog will open
  4. Click outside of the dialog
  5. Nothing happens!

Version

v35.28.0

Browser

Chrome

ctmayn avatar Aug 30 '23 18:08 ctmayn

@lesliecdubs, I'll resolve it, please, assign it to me.

Youssef11296 avatar Sep 22 '23 09:09 Youssef11296

Thanks for offering to resolve, @Youssef11296! This task requires some deeper consideration from Primer maintainers to ensure accessibility requirements are properly handled, so we wouldn't recommend this as an ideal contribution opportunity. Feel free to browse other open issues and let us know if there's any you'd be interested in working on instead.

lesliecdubs avatar Sep 26 '23 22:09 lesliecdubs

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Mar 24 '24 22:03 github-actions[bot]

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Sep 27 '24 23:09 github-actions[bot]