react icon indicating copy to clipboard operation
react copied to clipboard

Fix a bug in the useMnemonics hook to make it compatible with textareas

Open willglas opened this issue 3 years ago • 3 comments

Fix a bug in the useMnemonics hook that makes it incompatible with textarea elements. This bug manifested itself when I was trying to use a MarkdownEditor in an ActionMenu.

Closes #2316

Screenshots

No visual changes.

Merge checklist

  • [x] Added/updated tests
  • [ ] Added/updated documentation (didn't seem necessary)
  • [x] Tested in Chrome
  • [x] Tested in Firefox
  • [x] Tested in Safari
  • [x] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

willglas avatar Sep 07 '22 17:09 willglas

🦋 Changeset detected

Latest commit: 304846bc9542c45407a0dc8141b5420ed984c3e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 07 '22 17:09 changeset-bot[bot]

size-limit report 📦

Path Size
dist/browser.esm.js 78.81 KB (+0.02% 🔺)
dist/browser.umd.js 79.45 KB (+0.02% 🔺)

github-actions[bot] avatar Sep 08 '22 15:09 github-actions[bot]

Looks CI is failing (linting), we're good to go after that's fixed

siddharthkp avatar Sep 13 '22 08:09 siddharthkp

👋 Hi! Just checking, is this still useful?

siddharthkp avatar Oct 03 '22 15:10 siddharthkp