Fix a bug in the useMnemonics hook to make it compatible with textareas
Fix a bug in the useMnemonics hook that makes it incompatible with textarea elements. This bug manifested itself when I was trying to use a MarkdownEditor in an ActionMenu.
Closes #2316
Screenshots
No visual changes.
Merge checklist
- [x] Added/updated tests
- [ ] Added/updated documentation (didn't seem necessary)
- [x] Tested in Chrome
- [x] Tested in Firefox
- [x] Tested in Safari
- [x] Tested in Edge
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.
🦋 Changeset detected
Latest commit: 304846bc9542c45407a0dc8141b5420ed984c3e5
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @primer/react | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
size-limit report 📦
| Path | Size |
|---|---|
| dist/browser.esm.js | 78.81 KB (+0.02% 🔺) |
| dist/browser.umd.js | 79.45 KB (+0.02% 🔺) |
Looks CI is failing (linting), we're good to go after that's fixed
👋 Hi! Just checking, is this still useful?