react icon indicating copy to clipboard operation
react copied to clipboard

Include React 18 in peerDependencies

Open okuryu opened this issue 2 years ago • 1 comments

It includes react 18 in peerDependencies as an addition to #2196 changes.

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

okuryu avatar Aug 02 '22 01:08 okuryu

🦋 Changeset detected

Latest commit: 405f0392091d377f9651ceaa59ed9a6e2102346b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 02 '22 01:08 changeset-bot[bot]

I assume this PR adds support for React 18? Is there anything blocking from merging it?

tonimelisma avatar Aug 13 '22 05:08 tonimelisma

As per https://github.com/primer/react/issues/2202#issuecomment-1212577860, React 18 is not yet supported, but there are plans to support it in the future. It is my understanding that https://github.com/primer/react/pull/2196 is one of them. If the next release includes support for React 18, this PR could be merged as well.

okuryu avatar Aug 13 '22 09:08 okuryu

It says there's an internal issue. Why can't there be a public issue I could subscribe to in order to find out when React 18 will be supported?

tonimelisma avatar Aug 13 '22 16:08 tonimelisma

yeah, the issue related with react 18 should be tracked.

okuryu avatar Aug 15 '22 01:08 okuryu

Apologies, I still don't understand. Is there a public issue I can subscribe to in order to get notified when React 18 support has been implemented? Which one is it?

tonimelisma avatar Aug 15 '22 03:08 tonimelisma

Added to tracking issue for next release: https://github.com/primer/react/pull/2234 (we typically publish a new patch/minor release roughly every 10 days)

siddharthkp avatar Aug 16 '22 11:08 siddharthkp