react icon indicating copy to clipboard operation
react copied to clipboard

The PointerBox is being drawn incorrectly in all dark themes.

Open Matosov opened this issue 4 years ago • 1 comments
trafficstars

Pay attention for the line near the caret. Screenshot 2021-10-26 at 13 42 00

Matosov avatar Oct 26 '21 10:10 Matosov

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Sep 16 '22 23:09 github-actions[bot]

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Mar 22 '23 01:03 github-actions[bot]

Hey, so this issue as well as a somewhat related issue of the flash banner in dark mode will be solved with the new token release (primitives-v8). But we don't know when we release it yet.

The issue exists because in dark mode role colors use transparency.

A temp solution would be to add two background colors (using css gradient is probably the best solution here):

  • bottom layer bg = canvas.default of the mode
  • layer above = current role color e.g. success.subtle

This will create a non-transparent version.

lukasoppermann avatar Mar 28 '23 14:03 lukasoppermann

A temp solution would be to add two background colors (using css gradient is probably the best solution here):

* bottom layer bg = `canvas.default` of the mode

* layer above = current role color e.g. `success.subtle`

This will create a non-transparent version.

Hello! Thanks a lot for Your hint!

Matosov avatar Mar 28 '23 14:03 Matosov