octicons
octicons copied to clipboard
Allow custom props/attributes + Allow custom-ratio icons (e.g. 14x16)
Check out: https://github.com/marketplace/actions/fortify-scancentral-scan
The icons in the sidebar have viewBox="0 0 16 16" width="14" height="16"
.
This is currently not possible with this package because props other than predefined ones are ignored, so <SearchIcon width="14"/>
is equivalent to <SearchIcon"/>
<SearchIcon style={{width: '14px'}}/>
is also ignored.
Can you add a ...props
and/or ...props.style
in getSvgProps
?
Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.
Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.
I'd still like to see this
We intentionally prevent custom-ratios in octicons to avoid distorting the icons. There's more information in our usage guidelines on sizing: https://primer.style/octicons/guidelines/usage#sizing