github-vscode-theme icon indicating copy to clipboard operation
github-vscode-theme copied to clipboard

some syntax highlighting noticeably different to GitHub.com

Open domb5041 opened this issue 4 years ago • 4 comments

VS Code Screenshot 2020-06-05 at 12 34 23

Github.com Screenshot 2020-06-05 at 12 34 33

domb5041 avatar Jun 05 '20 11:06 domb5041

will you expand on this issue? I don't see any highlighting in the second photo for Github.com

isa3bel avatar Jun 29 '20 02:06 isa3bel

Sorry I meant syntax highlighting colours. I have amended the issue title

domb5041 avatar Jun 29 '20 11:06 domb5041

Agreed. Would love to see this theme's syntax colors exactly match github.com (for familiarity)

rileybrook avatar Jul 09 '20 16:07 rileybrook

I found some differences for C# too. The following settings seems to fix it for the light theme. I'm still checking for other differences but at one point I'll include these in a PR.

"editor.tokenColorCustomizations": {
  "textMateRules":[
    {
      "scope": ["storage.type"],
      "settings": { "foreground": "#6f42c1" }
    },
    {
      "scope":["entity.name.variable"],
      "settings": { "foreground": "#24292e" }
    }
  ]
}

What seems a bit strange is that the "storage.type" is explicitly set to red in the theme. Was there a reason for this? GitHub.com uses purple for this (in C#).

tamasvajk avatar Jul 29 '20 08:07 tamasvajk

Gonna close this as stale.

simurai avatar Jan 05 '23 06:01 simurai