github-vscode-theme icon indicating copy to clipboard operation
github-vscode-theme copied to clipboard

Fix syntax highlight for js/ts with export default

Open xeaone opened this issue 2 years ago • 1 comments

The syntax highlighting has unexpected color when using export default inline with class in js/ts.

Notice the curly brackets, semicolon, and parentheses all adopt the class name color. This color change also modifies other syntax. It seems as though that a possible solution might be to remove the scope "meta.export.default" (Dark and Light do not include this scope).

Before

image

After

image

Merge checklist

  • [x] Added/updated colors
  • [x] Added/updated documentation/README
  • [x] Tested in GitHub Light Default theme

Take a look at the Contribute section for more information on how test your changes locally.

xeaone avatar Sep 29 '23 21:09 xeaone

⚠️ No Changeset found

Latest commit: cf35a4cc207e8c08f12ca9972bd5b54fba2cf52d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 29 '23 21:09 changeset-bot[bot]