Semantic token highlighting

[charconstpointer]

It seems like this theme does not support semantic highlighting https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide

Github Theme with "gopls": { "ui.semanticTokens": true }

Dark+ with "gopls": { "ui.semanticTokens": true }

Dark+ with "gopls": { "ui.semanticTokens": false }

Will this be supported in the future?

[ShadiestGoat]

Yes I came here for the exact same reason - %v in go strings is not highlighted!

[ShadiestGoat]

I believe that there is actual support for semantic highlighting to some extent actually! On GitHub Dark Default, are differences between a regular string and %v,

It is just very low contrast

[ShadiestGoat]

[soraros]

@simurai I think this issue is not closed with #337 alone.

[simurai]

I think this issue is not closed with https://github.com/primer/github-vscode-theme/pull/337 alone.

Ohh.. ok. Let's reopen it for further improvements.