primer
Contrast issue with checkbox in merge editor
I'm using the GitHub Dark theme and I was thoroughly confused when the new three-way merge editor showed up in VS Code, I was confused because I didn't see a checkbox next to the conflict to accept a change. A colleague pointed out there was a checkbox when I shared the screenshot with them asking what to do, but they had trouble spotting it too. This issue isn't present in the default dark theme. I also noticed that the other dark variations don't have this issue, it's just GitHub Dark.
By comparison, the default dark theme:
I see now that GitHub Dark has been deprecated. So we should probably close this issue? Is it possible to notify people that this theme has been deprecated and probably won't be updated to take new features like the three-way merge editor into account?
Is this also a problem with the checkboxes in the settings? Seems not?
So maybe the merge editor checkboxes are different?
Tried to reproduce it by creating a merge conflict, but there doesn't seem to be any checkboxes. Even with the GitHub Dark Default theme.
Maybe they got replaced with text buttons (e.g. "Accept incoming") in the meantime? 🤔