GitHub Default and Dimmed themes don't have different color for components/elements

[max-programming]

I just noticed that the normal GitHub Theme is working fine but the GitHub Dimmed and GitHub Default don't have a different colour for components. And the components are of the same colour as the HTML elements. (React, Vue, Svelte)

GitHub Dark

GitHub Dimmed

[dominicegginton]

I will look into this. this might be due to the new themes following GitHub.com where this is no difference between HTML element tags and component tags.

[simurai]

Here a test on dotcom:

const Untitled = () => {
  return (
    <div>
      <Hello />
    </div>
  )
}

and yeah, it seems that there is no difference between HTML and component tags and both have the pl-ent class:

[dominicegginton]

I have opened #147 to get feedback on if this theme should strictly stay consistent to the GitHub.com syntax highlighting or implement extra syntax highlighting features such as this. Ultimately it's up the the GitHub primer team.

[max-programming]

I personally think it's better to have a different colour for components as it also makes this theme competitive to others

[simurai]

@dominicegginton Thanks for opening up a discussion. I'll also bring it up in our sync to discuss.

[Bosphoramus]

Yes please :( Bothers me way too much when reading code, components should have a different color.