github-vscode-theme icon indicating copy to clipboard operation
github-vscode-theme copied to clipboard
verified publisher icon primer

Semantic coloring over-uses orange for types in certain languages

Open simurai opened this issue 4 years ago • 2 comments

IDK, if you noticed this but semantic coloring really over-uses orange for types in certain languages, such as Java (see image). This is out of sync with Github.com. image

Originally posted by @jeffgennari in https://github.com/primer/github-vscode-theme/issues/117#issuecomment-764809787

simurai avatar Jan 22 '21 07:01 simurai

@jeffgennari moved this to its own issue.

Mind linking to the above code? 🙇 Just in case it's public, of course.

simurai avatar Jan 22 '21 07:01 simurai

Of course, there is nothing special about the code, it is just a bunch of object declarations in Java. Again, this happens when semantic coloring is enabled.

https://github.com/NationalSecurityAgency/ghidra/blob/2b08598dbabe6a9c911e712bd928e5f84fb00ee8/Ghidra/Features/Base/src/main/java/ghidra/util/state/ResultsState.java

jeffgennari avatar Jan 22 '21 10:01 jeffgennari