design icon indicating copy to clipboard operation
design copied to clipboard

Filters & Clearing Filters

Open emilybrick opened this issue 6 years ago • 0 comments

This came up in response to: https://github.com/github/github/pull/107687 (also https://github.com/github/github/issues/106809)

Problem & Goal

We don't have an easily repeatable pattern for clearing filters across the site, which leaves people to create a custom solution when needed. It may be worth coming up with a consistent pattern here.

I think it might be worth including Filters/Clear Filters patterns in the design guidelines to help inform future design decisions.

Screenshots

PRs and Issues screenshot 2019-02-14 09 32 57

File Diffs - Clear File Filters (Old) screenshot 2019-02-14 09 40 48

File Diffs - Clear File Filters (Updated)** screenshot 2019-02-14 09 41 24


Thoughts & Q's

  • how do we make it clear that filters have been selected if we're not using an input or any other indication that filters are being applied (like in the PRs/Issues pattern). For example, it's not that obvious that filters are applied the second image, the only difference is that the link changes to blue:

👇 no filters selected/applied 👇 screenshot 2019-02-14 09 54 46

👇 commit and file filters applied 👇 screenshot 2019-02-14 09 54 42

emilybrick avatar Feb 14 '19 14:02 emilybrick