css icon indicating copy to clipboard operation
css copied to clipboard

Reduce spacing between consecutive `<dt>` elements

Open FloEdelmann opened this issue 9 months ago • 8 comments

What are you trying to accomplish?

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dt:

multiple <dt> elements in a row indicate several terms that are all defined by the immediate next <dd> element

Example usage on GitHub: https://github.com/tummychow/git-absorb/blob/master/Documentation/git-absorb.adoc

Currently, those are separated by a 1rem margin, making them look like separate definitions (without a description):

grafik

What approach did you choose and why?

Reduce the spacing between consecutive <dt> elements to zero:

grafik

This is a similar approach to consecutive <li> elements and makes definition lists more readable.

What should reviewers focus on?

Can these changes ship as is?

  • [x] Yes, this PR does not depend on additional changes. 🚢

FloEdelmann avatar Mar 10 '25 14:03 FloEdelmann

🦋 Changeset detected

Latest commit: 64bedfac1e2ee7022f6a7f4127a9b30296977af6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Mar 10 '25 14:03 changeset-bot[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar May 09 '25 15:05 github-actions[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Jul 25 '25 17:07 github-actions[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Sep 23 '25 18:09 github-actions[bot]

@emilybrick sorry to ping you, but apparently the bot tries to close this issue in 7 days and this pull request is still relevant, so please keep it open (or review and merge it :wink:). Thanks! :slightly_smiling_face:

FloEdelmann avatar Sep 24 '25 07:09 FloEdelmann