css icon indicating copy to clipboard operation
css copied to clipboard

Drop “display: none” from details element contents styling

Open sideshowbarker opened this issue 1 year ago • 1 comments
trafficstars

What are you trying to accomplish?

Fixes #2592

What approach did you choose and why?

Removed display: none from details contents styling

What should reviewers focus on?

See https://github.com/primer/css/issues/2592#issue-2199903597 for repro/test steps

Can these changes ship as is?

  • [X] Yes, this PR does not depend on additional changes. 🚢

sideshowbarker avatar May 09 '24 11:05 sideshowbarker

🦋 Changeset detected

Latest commit: 887edd81a1b5664a892aaf8f00f2c9833c789c0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 09 '24 11:05 changeset-bot[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Jul 08 '24 12:07 github-actions[bot]

Friendly ping to reviewers

sideshowbarker avatar Jul 08 '24 13:07 sideshowbarker

Thanks for the ping @sideshowbarker. I’ll look at integrating this tomorrow and if it works out nicely we can look to ship it this week.

keithamus avatar Jul 08 '24 18:07 keithamus