brand icon indicating copy to clipboard operation
brand copied to clipboard

Fix missing CSS namespace on active IDE tab class

Open rezrah opened this issue 11 months ago • 3 comments

Summary

🧹 Tidying up

Contributor checklist:

  • [ ] All new and existing CI checks pass
  • [ ] Tests prove that the feature works and covers both happy and unhappy paths
  • [ ] Any drop in coverage, breaking changes or regressions have been documented above
  • [ ] UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • [ ] All developer debugging and non-functional logging has been removed
  • [ ] Related issues have been referenced in the PR description

Reviewer checklist:

  • [ ] Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • [ ] Check that tests prove the feature works and covers both happy and unhappy paths
  • [ ] Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After

Screenshot 2025-02-03 at 10 00 06

Screenshot 2025-02-03 at 10 02 13

rezrah avatar Feb 03 '25 10:02 rezrah

🦋 Changeset detected

Latest commit: 27de2dda31b6ece7dc7b78289d877729c5441940

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@primer/react-brand Patch
@primer/brand-docs Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 03 '25 10:02 changeset-bot[bot]

🟢 No design token changes found

github-actions[bot] avatar Feb 03 '25 10:02 github-actions[bot]

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

github-actions[bot] avatar Feb 03 '25 10:02 github-actions[bot]