Remove the hover text-decoration transition in `InlineLink`, `Accordion`, `Timeline` and align `Prose` with the updated `InlineLink` styles
Summary
We can't animate the text-decoration-thickness, we can animate a border, but since this is 1px transition, transitioning it is practically useless. Tested it on dotcom.
List of notable changes:
- *removed
transition: var(--brand-InlineLink-transition-timing) text-decoration;fromInlineLinkstyles. - *removed
transition: var(--brand-InlineLink-transition-timing) text-decoration;fromAccordionstyles. - *removed
transition: var(--brand-InlineLink-transition-timing) text-decoration;fromTimelinestyles. - Aligned
Proseinline link styles with the rest, since the animation didn't work anyways.
What should reviewers focus on?
- Hover effect on
InlineLink
Steps to test:
Supporting resources (related issues, external links, etc):
- https://github.com/github/github/pull/359872
Contributor checklist:
- [ ] All new and existing CI checks pass
- [ ] Tests prove that the feature works and covers both happy and unhappy paths
- [ ] Any drop in coverage, breaking changes or regressions have been documented above
- [ ] UI Changes contain new visual snapshots (generated by adding
update snapshotslabel to the PR) - [ ] All developer debugging and non-functional logging has been removed
- [ ] Related issues have been referenced in the PR description
Reviewer checklist:
- [ ] Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
- [ ] Check that tests prove the feature works and covers both happy and unhappy paths
- [ ] Check that there aren't other open Pull Requests for the same update/change
Screenshots:
Please try to provide before and after screenshots or videos
| Before | After |
|---|---|
🦋 Changeset detected
Latest commit: fa028d211ec3b613962e0ad756cef89464149acf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 6 packages
| Name | Type |
|---|---|
| @primer/brand-primitives | Patch |
| @primer/react-brand | Patch |
| @primer/brand-e2e | Patch |
| @primer/brand-fonts | Patch |
| @primer/brand-config | Patch |
| @primer/brand-storybook | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
🟢 No design token changes found
⚠️ Visual differences found
Our visual comparison tests found UI differences.
Please review the differences by using the test artifacts to ensure that the changes were intentional.
Artifacts can be downloaded and reviewed locally.
Download links are available at the bottom of the workflow summary screen.
Example:

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.
Thanks for tidying up the InlineLink component @stamat ✨ 🧹
Before we merge this, a few things to add...
- We'll need a changeset
- We should remove the base.json token file which declares the underlying token
- Optional (but better to do it in this single PR): We should also remove the same CSS rules from the other components that use this InlineLink style, which are Accordion, Prose and Timeline
@rezrah yo, I don't know what does this mean: We should remove the base.json token file which declares the underlying token 🤷
@rezrah ah I see I see, the design token for the variable right?