brand icon indicating copy to clipboard operation
brand copied to clipboard

Release tracking

Open primer-css opened this issue 1 year ago • 3 comments

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Patch Changes

@primer/[email protected]

Patch Changes

  • #776 06fd8476 Thanks @joshfarrant! - Added aria-describedby attribute to leading/trailing text and visuals in TextInput component

  • #781 ec6ffc36 Thanks @joshfarrant! - - Card component no longer expands to full width when fullWidth={false}

    • Card component no longer renders duplicate borders in dark mode when hasBorder={true}
  • #774 a6baf41d Thanks @joshfarrant! - Fixed issue where Button component would reflow and break over multiple lines when its text content exceeded the viewport width.

  • #768 0270f06d Thanks @danielguillan! - Improves spacing of RiverBreakout content

  • #760 6be1118d Thanks @joshfarrant! - Fixed a bug where passing a className to Hero.Label or Hero.Eyebrow would replace the default class.

  • #766 d10dc535 Thanks @danielguillan! - Adds internal paddings to River content on larger viewports

  • #767 299ad371 Thanks @danielguillan! - - Update the order of River children to ensure an acccessible markup strucuture.

    • On narrow viewports, the content and visuals are now flipped, with the visuals always placed first to enhance visual hierarchy.
  • #785 ec7d4023 Thanks @joshfarrant! - Fixed bug in Card component which caused the focus outline to not display when in dark-mode

@primer/[email protected]

Patch Changes

  • #776 06fd8476 Thanks @joshfarrant! - Added aria-describedby attribute to leading/trailing text and visuals in TextInput component

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

primer-css avatar Sep 23 '24 08:09 primer-css

❗ Pre-merge checklist

Please ensure these items are checked before merging.

✅ Preliminary checks

  • [x] All CI checks pass on this pull request
  • [x] Docs and Storybook previews open in a browser

🔌 Integration smoke tests

Dotcom

  • Performed successful integration test with github/github, as a primary consumer of Primer Brand
    • [x] Install RC: bin/npm install --save --save-exact @primer/react-brand@{RC_VERSION} Important: Verify that each workspace package has been updated correctly in their respective package.json files
    • [x] Run development server
    • [x] Manually verify release-specific bugfixes and/or features on the following pages:
      • /features/copilot
      • /enterprise
      • /enterprise/advanced-security
      • /articles/security
      • /articles/security/what-is-security-testing
      • /features/preview
      • /features/copilot/getting-started and /features/copilot
      • /solutions/devops
      • /education
      • /mobile
      • /contact-sales
      • /about/diversity
    • [ ] Manually compare production site to local instance for any non-release specific regressions

Subdomain sites

  • Performed successful integration test with githubuniverse.com, as a Tier 1 consumer of Primer Brand outside of the monolith.

    • [x] Run development server and verify no new console warnings or regressions are found
    • [x] Run local build to verify the release compiles correctly
    • [x] Manually performed side-by-side comparison with production
  • Performed successful integration test with https://resources.github.com/, as a Tier 1 consumer of Primer Brand outside of the monolith.

    • [ ] Run development server and verify no new console warnings or regressions are found
    • [ ] Run local build to verify the release compiles correctly
    • [ ] Manually performed side-by-side comparison with production

Sandboxes

  • [x] Works in CodeSandbox or StackBlitz
    • [x] New components render successfully
    • [ ] (optional) Tested in both SPA and SSR apps if release contains build changes

🤔 Cross-check (aka sanity test)

  • [x] Release notes accurately describe the changes made
  • [x] All bugfixes in this release have resolved their corresponding issues
  • [x] The issues for reverted PRs have been re-opened and commented on with a link to the reverted PR
  • [x] No noticeable regressions or side-effects have not been introduced as a result of changes in this release.
    • If they have, determine severity of the issue and consider hotfixing

After tests

  • [x] Add report summary of your findings, including any images. Use following template as a guide:

    #### Smoke test results
    
    - Feature 1 🟢 🟡 🔴 (choose one, depending on success levels)
    
      {insert screenshot}
    
    Release testing status: Ready to release 🟢 | Paused 🟡 🔴 (choose one and provide reason)
    

🚢 After merge

  • [x] Issue release comms in primer brand Slack channel
  • [ ] Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

github-actions[bot] avatar Sep 23 '24 08:09 github-actions[bot]

🟢 No design token changes found

github-actions[bot] avatar Sep 23 '24 08:09 github-actions[bot]

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

github-actions[bot] avatar Sep 23 '24 08:09 github-actions[bot]

Smoke test results

  • Accessibility improvements to the FormControl.Hint component.

    Non-blocking regression in Storybook fixture, which was introduced in this PR.

    https://github.com/user-attachments/assets/a071ead5-a931-457a-aba9-69dab95993d1

    Release testing status: Ready to release 🟢 (⚠️ we need to follow up on the above ☝️)

  • Increased spacing between River components on narrow viewports from 28px to 36px

    Verified in dotcom

    Screenshot 2024-10-28 at 10 14 13

    Release testing status: Ready to release 🟢

  • Added aria-describedby attribute to leading/trailing text and visuals in TextInput component

    Verified in dotcom, id correctly being applied to visuals/texts

    Release testing status: Ready to release 🟢

  • Fixed a bug where passing a className to Hero.Label or Hero.Eyebrow would replace the default class.

    Regression observed on Copilot feature page. Likely related to this PR. Caused by end-user overrides, which are no longer compatible with the latest release. We'll need to reach out to Brand Eng to on remediation steps.

    Screenshot 2024-10-28 at 10 51 55

    Release testing status: Paused 🟡

  • Button component would reflow and break over multiple lines

    Vertical padding regression observed on buttons with reflow. Likely due to removal of vertical padding in this PR.

    Screenshot 2024-10-28 at 11 01 56

    Release testing status: Ready to release 🟡 (Potentially non-blocking as reflow wasn't supported previously. We should remediate in follow up PR however.)

  • Adds internal paddings to River content on larger viewports

    1 unflagged visual breaking change and 1 regression observed on various River instances.

    Before After

    Screenshot 2024-10-28 at 11 21 19

    Screenshot 2024-10-28 at 11 20 57

    Ordering has changed on the page, but isn't flagged in the change log.

    Before After

    Screenshot 2024-10-28 at 11 19 38

    Screenshot 2024-10-28 at 11 19 41

    Release testing status: Paused 🔴

  • Add Icon component with new color primitives.

    Not exported from the package contrary to the change log entry.

    We need to either remove the entry and mark as a private component, or add the export to the root of the package.

    Release testing status: Paused 🔴

  • Fixed visual bug in RiverStoryScroll

    https://github.com/user-attachments/assets/91aa26a2-de5c-422a-9b24-818b814c8b61

    Verified in dotcom.

    Release testing status: Ready to release 🟢

rezrah avatar Oct 28 '24 11:10 rezrah

Smoke test results (2nd round)

  • Add Icon component with new color primitives.

    Previous issue resolved by removing changelog entry and keeping the component internal-only.

    Ready to release 🟢

  • Adds internal paddings to River content on larger viewports

    Previous issue resolved by applying paddings from large breakpoints only via this hotfix

    Ready to release 🟢

  • Button component would reflow and break over multiple lines

    Resolved in this hotfix. Vertical padding restored.

    Ready to release 🟢

Release good to go 🚀

rezrah avatar Oct 29 '24 11:10 rezrah