brand
brand copied to clipboard
🐛 [BUG] - Margin removed when using a `className` with `Hero.Label`
Describe the bug
When adding a className to a Hero.Label, it removes the bottom margin.
Reproduction steps
- Go to https://primer.style/brand/components/Hero/react
- In the editor, add
className="someClass"to theHero.Labelof the first example. - Notice how the bottom margin is gone.
I think the Hero-module--Hero-label--C\+rTh class (that adds the bottom margin) gets removed from the DOM once a custom class is added?
Expected behavior
The bottom margin should stay.
Screenshots
Browsers
Chrome
OS
Mac
Good spot, thanks @simurai.
I've got a PR here which resolves the issue
https://github.com/primer/brand/pull/760
Closing as the fix has shipped in v0.41.0