brand icon indicating copy to clipboard operation
brand copied to clipboard

Updating kitchen sink with comparisontable, anchornav and ctabanner

Open rezrah opened this issue 3 years ago • 3 comments

Summary

Updates our kitchen sink with recently added components. Applies to both Storybook and integration tests.

What should reviewers focus on?

  • Check the tests pass
  • Review storybook

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • [ ] All new and existing CI checks pass
  • [ ] Tests prove that the feature works and covers both happy and unhappy paths
  • [ ] Any drop in coverage, breaking changes or regressions have been documented above
  • [ ] New visual snapshots have been generated / updated for any UI changes
  • [ ] All developer debugging and non-functional logging has been removed
  • [ ] Related issues have been referenced in the PR description

Reviewer checklist:

  • [ ] Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • [ ] Check that tests prove the feature works and covers both happy and unhappy paths
  • [ ] Check that there aren't other open Pull Requests for the same update/change

Screenshots:

kitchen sink full screen with anchornav and ctabanner

rezrah avatar Dec 15 '22 12:12 rezrah

⚠️ No Changeset found

Latest commit: 05c2c054f1bae772e66ef103c115151ffdc5464c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 15 '22 12:12 changeset-bot[bot]

🟢 No design token changes found

github-actions[bot] avatar Dec 15 '22 12:12 github-actions[bot]

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

github-actions[bot] avatar Dec 15 '22 12:12 github-actions[bot]