BiomeJS port
Summary
Experiment for BiomeJS vs ESLint (v8) vs ESLint (v9)
| Tool | Lint Time | Format Time | Total Time | Source |
|---|---|---|---|---|
| Before: ESLint (v8) | 53s | 13s | 66s | CI Run |
| After: ESLint (v9) | 54s | 13s | 67s | CI Run |
| After: BiomeJS | 1s | 1s | 2s | CI Run |
Winner is:
-
Biome -
66s→2sTotal time taken
Reasons NOT to use it right now:
- Different plugin and IDE extensions lead to fragmented DevExp
- No interop with existing house rules for ESLint
List of notable changes:
What should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
- [ ] All new and existing CI checks pass
- [ ] Tests prove that the feature works and covers both happy and unhappy paths
- [ ] Any drop in coverage, breaking changes or regressions have been documented above
- [ ] UI Changes contain new visual snapshots (generated by adding
update snapshotslabel to the PR) - [ ] All developer debugging and non-functional logging has been removed
- [ ] Related issues have been referenced in the PR description
Reviewer checklist:
- [ ] Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
- [ ] Check that tests prove the feature works and covers both happy and unhappy paths
- [ ] Check that there aren't other open Pull Requests for the same update/change
Screenshots:
Please try to provide before and after screenshots or videos
| Before | After |
|---|---|
⚠️ No Changeset found
Latest commit: 79d5796f23bbfa835f10ca8c3a2f880d15de8026
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
🟢 No design token changes found
🟢 No unit test coverage changes found
All components and hooks with tests maintain the same coverage as the main branch.
🟢 No visual differences found
Our visual comparison tests did not find any differences in the UI.