Monospace

[rezrah]

Summary

🚧

List of notable changes:

What should reviewers focus on?

Steps to test:

Supporting resources (related issues, external links, etc):

Contributor checklist:

• [ ] All new and existing CI checks pass
• [ ] Tests prove that the feature works and covers both happy and unhappy paths
• [ ] Any drop in coverage, breaking changes or regressions have been documented above
• [ ] UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
• [ ] All developer debugging and non-functional logging has been removed
• [ ] Related issues have been referenced in the PR description

Reviewer checklist:

• [ ] Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
• [ ] Check that tests prove the feature works and covers both happy and unhappy paths
• [ ] Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before	After

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 141579d4e70dfc15bbb8c47bcb6d9c10a2715eca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions[bot]]

🔍 Design token changes found

View CSS variable changes

- --brand-fontStack-monospace: ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace;
+ --brand-fontStack-monospace: "Mona Sans Mono", monospace;

- --brand-fontStack-monospace: ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace;
+ --brand-fontStack-monospace: 'Mona Sans Mono', monospace;

[github-actions[bot]]

🟢 No unit test coverage changes found

All components and hooks with tests maintain the same coverage as the main branch.

[github-actions[bot]]

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

[simmonsjenna]

@rezrah I took a look through the instances — here is my recommendation:

1. For all testimonial components (as well as the testimonial nested in Prose), the job title/position of the quote's source can be smaller. It does not need the letter-spacing to be changed to var(--brand-text-letterSpacing-100) since monospace fonts already have ample letter-spacing.

Suggested changes:

font-size: var(--brand-text-size-100);
line-height: var(--brand-text-lineHeight-100);

2. We can also update the "Table of contents," "Featured," and "Topics" small titles on the SEO category and article pages to: font-weight: var(--base-text-weight-normal)

[rezrah]

@rezrah I took a look through the instances — here is my recommendation:

Thanks @simmonsjenna. Requested changes have been applied:

• Testimonial now uses 100 instead of 200.
• Monospace headings in the recipe templates now use 450 (our normal) instead of 500 weight. We don't have --base-text-weight-**regular**. We do however, have --base-text-weight-normal but it's at 450 instead of 400.

Let me know if I've missed anything. Diffs have been updated if you want to take another look at before/afters.