primefaces
fix: #6015 IconField compatibility with InputNumber
Given the CSS direct sibling selector, the appropriate padding for the input field could not be applied when InputNumber is used given it's nesting inside a span element.
Removing the direct sibling selector and styling more akin to V4 allows the nested input to be detected, however I can gladly update to extend and specifically target the input of the nested number input if preferred.
The :last-of-type selector on the p-input-icon element also fail in this regard due to the nesting, unless the markup is specifically set to have the InputIcon appear after the InputText.
###Defect Fixes #6015
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| primevue | ❌ Failed (Inspect) | Oct 4, 2024 0:00am |
1 Skipped Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| primevue-v3 | ⬜️ Ignored (Inspect) | Visit Preview | Oct 4, 2024 0:00am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for your contribution. To accept this PR, firstly primevue-sass-theme repo should be updated for version 3.
Thank you for pointing me in the right direction, that makes a lot of sense! I'll open a corresponding change there.
https://github.com/primefaces/primevue-sass-theme/pull/79
Closing this PR temporarily. Will be fixed for the next version.