primevue icon indicating copy to clipboard operation
primevue copied to clipboard

fix: global vue type augmentation

Open sceee opened this issue 1 year ago • 5 comments

Defect Fixes

Augment vue types instead of 'vue/types/vue' and '@vue/runtime-core' to fix incompatibility with other libraries caused by the current augmentation behavior

Fixes: #6199

sceee avatar Aug 09 '24 06:08 sceee

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 6:58am
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 6:58am

vercel[bot] avatar Aug 09 '24 06:08 vercel[bot]

please backport to v3

zyro23 avatar Aug 17 '24 19:08 zyro23

Cool, I've used pnpm patch to verify, this solution is an effective fix. Hope it gets merged soon.

byronogis avatar Aug 18 '24 12:08 byronogis

+1 to this being important to release for version 3 as well as 4

loneil avatar Aug 23 '24 22:08 loneil

🙏

frasza avatar Aug 25 '24 09:08 frasza

Not sure if this change from nuxt needs to be factored into this change: https://nuxt.com/blog/v3-13#vue-typescript-changes. Will this PR fix the issue ive been getting since upgrading to 3.13, in the plugin.d.ts file of my project the line containing ...node_modules/@primevue/nuxt-module/dist/runtime/plugin.client.mjs").default.. resolves as type of any?

CMeyer19 avatar Sep 03 '24 06:09 CMeyer19

Thanks a lot for your contribution!

mertsincan avatar Sep 04 '24 12:09 mertsincan

hello dear @mertsincan , can we get this update also for version 3 ? this really hinders updating vue and vue-tsc to the latest version for anyone who has not updated to primevue 4 :( thanks

fskarmeta avatar Nov 12 '24 10:11 fskarmeta