primevue icon indicating copy to clipboard operation
primevue copied to clipboard

Menu:Design Token does not work

Open ShiYaoDiving opened this issue 1 year ago • 8 comments

Describe the bug

Design token do not work on MENU, these is no 'PC{id}' in the <DIV>

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-fhzqdg?file=src%2FApp.vue

PrimeVue version

4.0.1

Vue version

4.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Just like the case demonstrating.

does not work

Expected behavior

I think there must be some code missing....

ShiYaoDiving avatar Jul 27 '24 01:07 ShiYaoDiving

The same situation also has: popover, menu

leosin avatar Jul 30 '24 14:07 leosin

I think it is because of the <Portal> of Menu.vue. If I remove the

<Portal :appendTo="appendTo" :disabled="!popup">

(line2 in Menu.vue). The Design Token will work

ShiYaoDiving avatar Aug 05 '24 07:08 ShiYaoDiving

I think it because of the Portal is outside of the div.. it iwll influence all components with that: autocomplete.calendar,,cascadeselect colorpicker contextmenu dialog dropdown menu multiselect overlaypanel....

ShiYaoDiving avatar Aug 05 '24 07:08 ShiYaoDiving

Running into the same problem here. Something of note, the problem only occurs when using a scoped design token. I can set the style using design tokens in my global component preset theme. However that isn't what I want to do, I want to use a scoped token to only style a specific menu and not all of them.

This is only primevue 4.0.4.

cromerc avatar Aug 07 '24 03:08 cromerc

That’s right and i think it just because of the <Protal> If you remove them from Menu.vue and the dt will work

ShiYaoDiving avatar Aug 07 '24 04:08 ShiYaoDiving

Is this the same matter also for the Dialog component?

https://stackblitz.com/edit/cnrvm8?file=src%2FApp.vue

micvm avatar Aug 08 '24 16:08 micvm

Thanks for the reports. It'll be fixed for version 4.0.6.

tugcekucukoglu avatar Aug 23 '24 13:08 tugcekucukoglu

Oh this is a bug.. I thought I was doing something wrong

oliver139 avatar Aug 28 '24 09:08 oliver139

@tugcekucukoglu Tooltip still doesn't react on changes of Design Tokens property.

jbsaltship avatar Sep 12 '24 10:09 jbsaltship

Button and Tabs Also don't seem to work.

svwezel avatar Sep 19 '24 09:09 svwezel

The select component is valid here before, but it is not valid today

2234839 avatar Sep 20 '24 08:09 2234839

Thanks for the stackblitz examples. We are investigating the issue, which will be fixed for the next version 4.1.0.

tugcekucukoglu avatar Oct 01 '24 10:10 tugcekucukoglu

Button and Tabs Also don't seem to work.

@svwezel Could be https://github.com/primefaces/primevue/issues/6129. If you roll-back to Vue 3.5.5, does it work?

deisner avatar Oct 01 '24 15:10 deisner